Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(p2p): remove availability checks from retriever #835

Merged
merged 1 commit into from
May 12, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented May 9, 2024

PR Standards

This PR removes the availability checks from the retriever, since it requires additional syncing with DA and availability checks are not really necessary at this point where sequencers are trusted and fraud proofs are not enabled yet in full-nodes.

Opening a pull request should be able to meet the following requirements


Close #834

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

Sorry, something went wrong.

@srene srene self-assigned this May 9, 2024
@srene srene requested a review from a team as a code owner May 9, 2024 10:26
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.40%. Comparing base (851b312) to head (aab2158).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
- Coverage   40.44%   40.40%   -0.05%     
==========================================
  Files         120      119       -1     
  Lines       18935    18868      -67     
==========================================
- Hits         7659     7623      -36     
+ Misses      10201    10170      -31     
  Partials     1075     1075              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtsitrin
Copy link
Contributor

I'm fine to merge it,
but to notice, it affects not only full nodes but also a sequencer that needs to be synced initially
(in syncBlockManager function)

@mtsitrin mtsitrin merged commit b16cfb6 into main May 12, 2024
6 of 7 checks passed
@mtsitrin mtsitrin deleted the srene/834-remove-avail-checks branch May 12, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove da availability checks from happy path
3 participants